search

openlink / iODBC

An open-source ODBC driver manager and SDK that facilitates the development of database-independent applications on linux, freebsd, unix and MacOS X platforms.
http://www.iodbc.org/
Other
162 stars 52 forks source link

autogen.sh uses incorrect test to determine if a tool is installed #64

Closed vt-pongrass closed 3 years ago

vt-pongrass commented 3 years ago

On my computer, I don't have the GNU autotools installed so when autogen.sh is executed, I expected it to report the tools were missing. It does not do this. I believe it's because line 109 and line 131 are both using the wrong test:

if test -z "VERSION"

instead of

if test -z "$VERSION"

When I changed my copy, the missing tools were then correctly reported as missing.

TallTed commented 3 years ago

Development will be looking into this shortly. To help us prevent this issue going forward, would you please also provide your OS name and version?

/cc @smalinin @pkleef @openlink

pkleef commented 3 years ago

I have pushed a fix for this issue to the develop branch.

TallTed commented 3 years ago

For ease of future reference, that fix is in https://github.com/openlink/iODBC/commit/aa40083c398adc32e7ff875b81b27958e7a448e0.