openllb / hlb

A developer-first language to build and test any software efficiently
https://openllb.github.io/hlb/
Apache License 2.0
108 stars 12 forks source link

Add platform prefix to MultiWriter #331

Closed yun-wang closed 2 years ago

yun-wang commented 2 years ago

This PR adds a platform prefix to Buildkit progress output, because the output is confusing when Newt solves multi-platform builds in parallel. However, the current implementation doesn't cover all output in plain mode. Buildkit doesn't give us a way to inject prefixes to the rest of the progress output:

Progress output with the current implementation:

Screen Shot 2022-08-11 at 4 07 09 PM

Let me know what you think, or if you have any suggestions.

hinshun commented 2 years ago

I think the plain log output only prefixing the "header" is fine. They are always outputted in chunks together with the "header" so from a readability standpoint it looks good.