openllb / hlb

A developer-first language to build and test any software efficiently
https://openllb.github.io/hlb/
Apache License 2.0
112 stars 12 forks source link

Include last modified time in LocalUniqueID #338

Closed aaronlehmann closed 2 years ago

aaronlehmann commented 2 years ago

I ran into a situation where a "local" mount was wrongly deduped with a "local" from a concurrent solve that was created by another hlb process before some files in that dir were modified.

By including the last modified timestamp in the unique ID, we an avoid this deduplication in the case where a file has actually changed.

hinshun commented 2 years ago

Nice!