search

openlookeng / hetu-core

570 stars 423 forks source link

BugFix: Fix for immediate query fail due to unhandled exception in httpRequest for resumable failure #351

Closed ahanapradhan closed 2 years ago

ahanapradhan commented 2 years ago

What type of PR is this?

/kind bug

What does this PR do / why do we need it:

Handling of PageTransportErrorException in buffer client.

Which issue(s) this PR fixes:

Fixes # fixes immediate query fail bug caused by https://github.com/openlookeng/hetu-core/pull/336

Special notes for your reviewers:

it-is-a-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ahanapradhan To complete the pull request process, please assign fbird2020 You can assign the PR to them by writing /assign @fbird2020 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openlookeng/hetu-core/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
Nitin-Kashyap commented 2 years ago

lgtm, pending testcase addition

sraghunandan commented 2 years ago

/sync

it-is-a-robot commented 2 years ago

@sraghunandan: This pr has been synchronized to the Gitee Repository

In response to [this](https://github.com/openlookeng/hetu-core/pull/351#issuecomment-1129916421): >/sync Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [opensourceways/test-infra](https://github.com/opensourceways/test-infra/issues/new?title=Prow%20issue:) repository.