search

openlookeng / hetu-core

570 stars 423 forks source link

Update PrestoS3FileSystem.java #403

Open ShefronYudy opened 1 year ago

ShefronYudy commented 1 year ago

The LOG.debug("destination does not exist"); should be log.debug("destination does not exist");， because the LOG is parent FileSystem's reference.

What type of PR is this?

bug

What does this PR do / why do we need it:

When use LOG to print some messages, The log class of log message is not the current PrestoS3FileSystem, but the parent FileSystem.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewers:

it-is-a-robot commented 1 year ago

Thanks for your pull request.

The authors of the following commits have not signed the Contributor License Agreement (CLA):

83e13959 | Update PrestoS3FileSystem.java

The LOG.debug("destination does not exist"); should be log.debug("destination does not exist");， because the LOG is parent FileSystem's reference.

Please check the FAQs first. You can click here to sign the CLA. After signing the CLA, you must comment "/check-cla" to check the CLA status again.

it-is-a-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ShefronYudy To complete the pull request process, please assign haochending You can assign the PR to them by writing /assign @haochending in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openlookeng/hetu-core/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
it-is-a-robot commented 1 year ago

Welcome @ShefronYudy!

It looks like this is your first PR to openlookeng/hetu-core 🎉.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if openlookeng/hetu-core has its own contribution guidelines. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to MindSpore. :smiley:

Nitin-Kashyap commented 1 year ago

/sync

it-is-a-robot commented 1 year ago

@Nitin-Kashyap: sync pull request is restricted to collaborators

In response to [this](https://github.com/openlookeng/hetu-core/pull/403#issuecomment-1352970971): >/sync Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [opensourceways/test-infra](https://github.com/opensourceways/test-infra/issues/new?title=Prow%20issue:) repository.