search

openlookeng / hetu-core

570 stars 423 forks source link

Add UT's for FixedCountNodeAllocator and TaskDescriptorStorage #410

Closed siddarth171994 closed 1 year ago

siddarth171994 commented 1 year ago

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

kind task

What does this PR do / why do we need it: This PR adds UT for FixedCountNodeAllocator and TaskDescriptorStorage

Which issue(s) this PR fixes:

Fixes #409

Special notes for your reviewers:

it-is-a-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: siddarth171994 To complete the pull request process, please assign haochending You can assign the PR to them by writing /assign @haochending in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openlookeng/hetu-core/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
it-is-a-robot commented 1 year ago

Welcome @siddarth171994!

It looks like this is your first PR to openlookeng/hetu-core 🎉.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if openlookeng/hetu-core has its own contribution guidelines. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to MindSpore. :smiley:

sraghunandan commented 1 year ago

/sync

it-is-a-robot commented 1 year ago

@sraghunandan: This pr has been synchronized to the Gitee Repository

In response to [this](https://github.com/openlookeng/hetu-core/pull/410#issuecomment-1354605855): >/sync Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [opensourceways/test-infra](https://github.com/opensourceways/test-infra/issues/new?title=Prow%20issue:) repository.