Closed dlutz2 closed 6 months ago
Hi dlutz2, this should now have been addressed in https://github.com/openlvc/disco/pull/64
We've removed all custom PDUs out of the codebase, and provided a way for 3rd parties to register custom PDU types and HLA mappers decoratively.
To register a custom PDU:
Registering HLA mappers for custom PDUs/HLA Objects is a similar process:
To integrate a new custom PDU into disco, it is necessary to add a value to the PduType enumeration which requires a fork of the whole codebase and results in a distro which is not compatible with the original disco. If the PduType was a e.g. a Map, it would be possible to extend disco using disco.jar directly. Since this issue will also occur with any enum based on the SISO enums (latest version just out with a bunch of new entities), it would seem to be a good idea there as well. thanks
BTW, we convert all SISO data to JSON and load them at runtime to avoid the above. We would like to do the same with PDUs.