MOM support for service invocation information and exceptions

openlvc / portico

Portico is an open source, cross-platform, fully supported HLA RTI implementation. Designed with modularity and flexibility in mind, Portico is a production-grade RTI for the Simulation and Training Community, so come say hi!

http://www.porticoproject.org

151 stars 81 forks source link

MOM support for service invocation information and exceptions #237

Closed timpokorny closed 6 years ago

timpokorny commented 6 years ago

Summary

Add support for the following calls MOM request/report interactions:

Report: HLAreportException
Report: HLAreportServiceInvocation
Report: HLAreportMOMexception
Report: HLAreportFederateLost

Acceptance Criteria

Once complete, Portico shall:

[x] be able to confirm this functionality through the existing unit test suites

michaelrfraser commented 6 years ago

@tpr1 just wondering if you can give me some guidance as to what you will be using the HLAreportServiceInvocation notification for? Do you require the parameters that the service was invoked with, or just the name of the service itself?

tpr1 commented 6 years ago

I have no plans to use the supplied or returned arguments.

I am worried about deadlock situations that arise due to poorly configured federates. For instance, a federate might sit in a loop waiting for a receive order message that will never arrive because all its peers who publish that message have sent an advance time request. The HLAreportServiceInvocation could be used as an interrupt flag to trigger some recovery action in cases where deadlock is possible; it would really only need the service name and success indicator for that purpose.

michaelrfraser commented 6 years ago

Thanks Thomas, will get onto it straight away!

michaelrfraser commented 6 years ago

PR submitted to #273.

All features have been implemented with the following notes:

Support for HLAreportMomInteraction was added in previous work (#270)
Code for sending the HLAfederateLost interaction has been added, however at the time of writing the mechanism to detect a lost federate has not been implemented. A new ticket will be raised to wire this up.
Service Invocation reporting and Exception reporting currently can only be enabled through the HLAsetServiceReporting and HLAsetExceptionReporting interactions. 1516e specifies that they can be turned on federation wide through the switches section of the FDD, however at the time of writing there is no mechanism to extract this data and disseminate it to newly joined federates.

Placing ticket in review.

timpokorny commented 6 years ago

Merged!