PORT-256 Defer linking until all FOM modules have been parsed and merged

michaelrfraser commented 6 years ago

This PR has been submitted for bug ticket #256

When we initially developed the datatype parsing system, we worked under the assumption that all FOM modules were standalone in their own right - e.g. the datatypes has declarations for all datatypes that are referenced in the module.
However in the modular RPRv2 FOM this is not the case. Datatypes, attributes and parameters can all reference datatypes that are declared soley in other FOM modules.
As such a DatatypePlaceholder is now placed for all datatype links at parse time. Linking is deferred until all FOM modules have been parsed and merged, and the standard MIM has been inserted.
Updated parsing unit tests to perform the delayed linking process.

Note: Branch has been merged off the PORT-254 branch.

timpokorny commented 6 years ago

@michaelrfraser - When we merge this are we going to need to update the base line JVM? I noted the first commit was a pathing one.

timpokorny commented 6 years ago

I also wonder if we should add both types of path to the path.

michaelrfraser commented 6 years ago

@timpokorny The first commit was for a separate issue (port-254), but I had to branch from that so that it compiled on my system :) There's another separate PR for port-254 hanging around.

openlvc / portico

PORT-256 Defer linking until all FOM modules have been parsed and merged #257