openlvc / portico

Portico is an open source, cross-platform, fully supported HLA RTI implementation. Designed with modularity and flexibility in mind, Portico is a production-grade RTI for the Simulation and Training Community, so come say hi!
http://www.porticoproject.org
151 stars 81 forks source link

Issue #280: Ignored `federateType` Parameter #281

Closed adlaws closed 5 years ago

adlaws commented 5 years ago

This commit contains updates to allow the federateType parameter to be correctly utilised by 1516e federates. (see https://github.com/openlvc/portico/issues/280 for more details on the problem)

The updates also include changes to the unit tests to check for correctness.

In cases where only the federateName parameter is provided, this is used to populate the federateType parameter (where necessary). This is in keeping with the existing behaviour, and avoids the alternative of having a null or empty String for the federateType instead, and the associated problems/value checking which this would entail.

adlaws commented 5 years ago

No worries - I'll update the test cases first thing tomorrow and push the changes.