search

openlvc / portico

Portico is an open source, cross-platform, fully supported HLA RTI implementation. Designed with modularity and flexibility in mind, Portico is a production-grade RTI for the Simulation and Training Community, so come say hi!
http://www.porticoproject.org
151 stars 81 forks source link

Issue #280: Ignored `federateType` Parameter for `port219-central-rti` branch #282

Closed adlaws closed 5 years ago

adlaws commented 5 years ago

This commit contains updates to allow the federateType parameter to be correctly utilised by 1516e federates. (see #280 for more details on the problem) in the port219-central-rti branch

The updates also include changes to the unit tests to check for correctness.

In cases where only the federateName parameter is provided, this is used to populate the federateType parameter (where necessary). This is in keeping with the existing behaviour, and avoids the alternative of having a null or empty String for the federateType instead, and the associated problems/value checking which this would entail.

adlaws commented 5 years ago

As far as I can tell the relevant tests pass, but the unit/integration tests appear to be failing all over the place at the moment, so I'm can't be 100% sure I haven't broken something subtle I guess... 😞

timpokorny commented 5 years ago

I'll take a look. This one fails sometimes on Travis for unknown reasons.