openly-retro / stellaris-machine-robot-expansion

Reviving XVCV's "Machine & Robot Expansion" mod
https://steamcommunity.com/sharedfiles/filedetails/?id=3163759042
2 stars 2 forks source link

Some councilor traits can be given to the ruler but are disabled by the game >:( #87

Closed openly-retro closed 6 months ago

openly-retro commented 6 months ago

Traits like leader_trait_expertise_voidcraft_3 can be given to councilors and also the ruler. The ruler is a councilor. But there is nothing in the base game trait to say that the trait should not be applied to the ruler (who is also a councilor). However there are many traits that DO say "is_ruler = no" in the potential.

Why would PDX not explicitly say is_ruler = no for these traits that then show a custom warning in the game?

job_traits_on_ruler_warning:1 "$TRIGGER_FAIL$ §RSome effects might be disabled when the Leader is the Empire's Ruler.§!"

There isn't anything that I can find in the base game data to indicate when this warning will show. PDX have internalized this secret list and not exposed it to players.

THE FIX

  1. Find these traits and hunt them down -- thankfully there appear to be a handful
  2. Overwrite the vanilla versions of these traits -- add is_ruler = no to them
  3. Create custom ruler-only versions of these traits -- potential : is_ruler = yes
  4. Create a way to fix a leader who has these bugged traits on them -- they can be removed in the core modifying GUI with the T3 version
openly-retro commented 6 months ago

This is also a problem because sometimes the ONLY pick is from three traits that give absolutely no benefit to the ruler.

openly-retro commented 6 months ago

Good news, this will be addressed in 3.11 Stellaris

Fixed gestalt scientists getting research expertise traits when those traits had no effect for them

https://forum.paradoxplaza.com/forum/developer-diary/stellaris-dev-diary-331-custodian-fixes-in-eridanus.1624121/

openly-retro commented 6 months ago

For now I'm removing these from the core modifying GUI. it's done in https://github.com/openly-retro/stellaris-machine-robot-expansion/pull/96/commits/184e25626f3d2e6e340453bcef25eec8eda6109d