Removing DE/DA/RS civic via Source Code AP doesn't refund the used civic that was removed

[openly-retro]

See https://discord.com/channels/378985949373399040/676376359513227304/1209230779440439336

ArchmageMC did some playtesting and found the following:

Yeah Source code reprogramming doesn't give the civic slot until you run the project And it does and doesn't give +1 civic. If you remove your unique empire trait, you get +1 civic, but would actaully need +2 civics if you were getting rid of a civic. when you start like a normal robot empire and take it, you get +1 civics like normal when aquiring a unique empire type And when you swap them around, you get +1 civic as well

And if you remove DE/DA/RS you DON'T get +1 civic. Well, you do, but you aren't refunded the civic slot you just gave up. So instead of being +3 civic after running the project, I'm +2, even though that means I'd only have 3 civics total not 4 like the project should allow. So what I can suggest is either a new button or allowing to select the button for your unique empire type if you have one that lets you 'affirm' your empire type for +1 civic slot in the way of "code optimization" And for the "removing the civic", change the paramater to +2 civics instaed of +1 to fix the bug with it.

Next steps:

• Check the code for how the DE/DA/RS civic is removed and see what's going on

Possible fixes:

• Give +1 civic right away
• Give +1 civic right away, +1 after the special project

[openly-retro]

Testing as non DE:

• researched all tech
• Have 3 civic slots
• Completing the project didnt give extra picks, but added DE for 4 civics total

Testing as DE

• 3 picks total before project, DE + 2 others
• completing project didnt give any more civic slots
• Remove DE gives me back the 1 civic point
• Change to DA/RS just replaces it
• After project, 3 civics total

[openly-retro]

My thoughts:

• For non DE/DA/RS empires, dont let the special project get launched unless there's 1 unused civic available

can use civics_count > N as a limit

[openly-retro]

ArchmageMC suggested

have one of its requirements be the tech that gives +1 civic points Uh... galactic adminsitration I think its called?

Going to try adding that as a limit

[openly-retro]

Testing:

new game, open console

• research_technology tech_manifest_destiny
• research_technology xvcv_mdlc_tech_organic_base_code_study
• unity 99999

I ended up adding a tech limit to the AP

[openly-retro]

in progress -- dialogue boxes to remove civics after adding DE/DA/RS

with check ONLY if civics are >= 3 at project competion

also add a monthly check that the source code was overhauled. set a country flag &chek every month in case the player X out of the dialogue

[openly-retro]

This is all patched up now. plus new graphics added.