search

openmainframeproject / cobol-check

A testing framework for Cobol applications
Apache License 2.0
78 stars 28 forks source link

Add duplication check for test suites and test cases #285

Closed literalEval closed 1 year ago

literalEval commented 1 year ago

Fixes: #217

This PR enforces a check on Test Suite names and Test Case names so that no two Test Suites can have the same name, and the same for two test cases in the same suite. Also created the respective exception for both cases.

literalEval commented 1 year ago

@dakaa16 @Rune-Christensen please review. Thanks.

dakaa16 commented 1 year ago

Hi @literalEval Thank you for contributing. I will be able to thoroughly review your PR on monday. At a quick glance, it seems to be missing some unit tests.

literalEval commented 1 year ago

@dakaa16 Thanks. I'll add tests in the meantime.

literalEval commented 1 year ago

Hello @dakaa16 I was waiting for your review 😅

Rune-Christensen commented 1 year ago

Hi @literalEval

Please add some unit tests, to verify that the changes function as expected. Thanks :-)

Rune-Christensen commented 1 year ago

Tests add through another pull request. Thank you for contributing :-D

literalEval commented 1 year ago

@Rune-Christensen sure :)