openmainframeproject / cobol-check

A testing framework for Cobol applications
Apache License 2.0
79 stars 28 forks source link

Issue with program with value after position 72 #335

Open Thibaut69 opened 1 year ago

Thibaut69 commented 1 year ago

When in your input cobol program, you have a string from position 73 to 79 (here value "MP029C "), this string is added as a new line in the generated cobol program like you can see below : image

It could be great to ignore this string to prevent bad generation like we have here with extra "dirty" lines.

samdion1994 commented 1 year ago

Hi @Thibaut69,

Glad to have you working with CC hope you are enjoying :)!

Published a branch with a fix feel free to use it for this Issue. I will be doing a PR in the future that will implement that fix.

Thibaut69 commented 1 year ago

Hi @samdion1994, thanks a lot for your quick answer.

I'm not familiar with gradle, I've download your new branch and try to build with command : gradle build (I had 8 tests not OK, see below) image

If i try to build without the test with command : gradle build -x test, I have a jar under build/libs

But when i try to launch ".\cobol-check.cmd -p myprog", i got an issue : "no main manifest attribut in the cobol-check.jar" I modified the manifest file like the one of the 0.2.8 distrib of CC, and then my jar seems to start

If there is a better way to do, can you provide me the piece of documentation for newbie dev on the project ? :)

Then, when i tried to generate the cobol, I still see the problem with added lines image

samdion1994 commented 1 year ago

Hi @Thibaut69,

You are right... I add a validation can you pull and rebuild the dist then try is out :)!

Thibaut69 commented 1 year ago

Hi @samdion1994, just tested and there is no more new lines between Identification division to FILE-CONTROL, but below DATA DIVISION the new lines are still there : image