search

openmainframeproject / cobol-programming-course

Training materials and labs for a "Getting Started" level course on COBOL
https://openmainframeproject.org/projects/cobol-programming-course/
Creative Commons Attribution 4.0 International
3.04k stars 589 forks source link

adding a chapter on Sort and merge #249

Closed ahmedEid1 closed 2 years ago

ahmedEid1 commented 3 years ago

Signed-off-by: ahmedEid1 ahmedeid6422@gmail.com

This PR adds a chapter on SORTand MERGEVerbs

Currently, there are no labs for the chapter.

ahmedEid1 commented 3 years ago

@MikeBauerCA this is the same PR, I kind of broke my Git history, so I recreate the PRs on new branches. sorry, if this caused any problems.

I added all the comments that were on the original PR

ahmedEid1 commented 3 years ago

@MikeBauerCA

Please review how other chapters are set up with a brief introduction followed by a table of contents for the chapter. Try to be consistent with that format.

DATA DEVISION >> DATA DIVISION

MikeBauerCA commented 3 years ago

Was the following resource leveraged to construct this content? http://www.csis.ul.ie/cobol/course/SortMerge.htm

ahmedEid1 commented 3 years ago

Was the following resource leveraged to construct this content? http://www.csis.ul.ie/cobol/course/SortMerge.htm

Yes, the structure of the chapter and some of the content is from it

ahmedEid1 commented 3 years ago

Sorting and Merging files - Google Chrome 8_14_2021 6_41_56 PM I got the problem. I thought it was a blog post or something so I didn't check for Copyrights (which is a big mistake).

should I remove all the parts from this resource, and rewrite the chapter?

MikeBauerCA commented 3 years ago

Yes or alternatively, you could seek approval from the author and see if they would like to be involved in this initiative.

ahmedEid1 commented 3 years ago

Didn't get a response back from the author, so I rewrote the chapter.