fix FCP leftover when detach the last volume

openmainframeproject / feilong

Feilong is a open source z/VM cloud connector project under the Open Mainframe Project umbrella that will accelerate the z/VM adoption, extending its ecosystem and its user experience. It provides a set of APIs to operate z/VM including guest, image, network, volume etc.

https://www.openmainframeproject.org/projects/feilong

Apache License 2.0

36 stars 70 forks source link

fix FCP leftover when detach the last volume #697

Closed jackydalong closed 1 year ago

jackydalong commented 1 year ago

The PR changes def undedicate() in smtLayer/changeVM.py

Before this PR, the function
- first, run cmd-a (Image_Device_Undedicate_DM)
- if rc == 0,
  - run cmd-b (Image_Device_Undedicate)
With this PR, the function
- first, run cmd-a (Image_Device_Undedicate_DM)
- if rc == 0 or (rc == 404 and rs == 8)
  - run cmd-b (Image_Device_Undedicate)

Signed-off-by: Da Long Wang shdlwang@cn.ibm.com

jackydalong commented 1 year ago

UT pass locally

(.venv3) [shdlwang@core2-ut feilong]$ tox  -e pep8 -e py36
  pep8: commands succeeded
  py36: commands succeeded
  congratulations :)