openmainframeproject / feilong

Feilong is a open source z/VM cloud connector project under the Open Mainframe Project umbrella that will accelerate the z/VM adoption, extending its ecosystem and its user experience. It provides a set of APIs to operate z/VM including guest, image, network, volume etc.
https://www.openmainframeproject.org/projects/feilong
Apache License 2.0
36 stars 70 forks source link

[master] add pchids not-exist-in-any-template in the response of edit_fcp_template API #738

Closed wngzhe closed 1 year ago

wngzhe commented 1 year ago

code change: change return of edit_fcp_template add orphan values in return value dict

result example:

{
              'fcp_template': {
                'name': 'bjcb-test-template',
                'id': '36439338-db14-11ec-bb41-0201018b1dd2',
                'description': 'This is Default template',
                'host_default': True,
                'storage_providers': ['sp4', 'v7k60'],
                'min_fcp_paths_count': 2,
                'pchids': {
                    'add' : ['C'],
                    'delete' : {
                        'all': ['D', 'E'],
                        'not_exist_in_any_template': ['F']
                    },
                    'all' : ['A', 'B', 'C']
                }
              }
            }
jackydalong commented 1 year ago

suggest

  1. changing the title from

    change return of edit_fcp_template add orphan values in return value dict

    to

    add pchids not-exist-in-any-template in the response of edit_fcp_template API
  2. add the following example to the original comment

    {
    'fcp_template': {
        ...
        'pchids': {                  
            'add' : ['C'],                       
            'delete' : {                             
                'all': [D, E],                    
                'not-exist-in-any-template': [D]  <--- pchids not exist in any template
            },
            'all' : ['A', 'B', 'C']              
         }
    }
    }

    @wngzhe