search

openmainframeproject / feilong

Feilong is a open source z/VM cloud connector project under the Open Mainframe Project umbrella that will accelerate the z/VM adoption, extending its ecosystem and its user experience. It provides a set of APIs to operate z/VM including guest, image, network, volume etc.
https://www.openmainframeproject.org/projects/feilong
Apache License 2.0
35 stars 70 forks source link

Adding logic to fetch memory util with free command. #760

Closed ShrmaRajat closed 10 months ago

ShrmaRajat commented 11 months ago

Signed-off-by: Rajat Sharma rajat.sharma12@ibm.com

ShrmaRajat commented 11 months ago

@jichenjc @bjhuangr @SeanHQF PTAL

SeanHQF commented 11 months ago

@ShrmaRajat have you fetched the latest code to change?

SeanHQF commented 11 months ago

@jichenjc @bjhuangr pls help review, thx

ShrmaRajat commented 11 months ago

@ShrmaRajat have you fetched the latest code to change?

yes

SeanHQF commented 11 months ago

@ShrmaRajat you have the status to fix.

ShrmaRajat commented 10 months ago

@jichenjc @SeanHQF updated PR with suggested approach, PTAL.

SeanHQF commented 10 months ago

Solve the conflict pls

bjhuangr commented 10 months ago

please fix the pep8 error and address comments from Robin

ShrmaRajat commented 10 months ago

fixed UTs. in pep8, I see this failure which not related to my changes. ./zvmconnector/restclient.py:1102:12: E721 do not compare types, for exact checks use is / is not, for instance checks use isinstance()

ShrmaRajat commented 10 months ago

please fix the pep8 error and address comments from Robin

added exception as per Robin's comment

SeanHQF commented 10 months ago

pls update it with the latest code of master, thx