openmainframeproject / feilong

Feilong is a open source z/VM cloud connector project under the Open Mainframe Project umbrella that will accelerate the z/VM adoption, extending its ecosystem and its user experience. It provides a set of APIs to operate z/VM including guest, image, network, volume etc.
https://www.openmainframeproject.org/projects/feilong
Apache License 2.0
35 stars 70 forks source link

Missing function for getting disks list #796

Closed Bischoff closed 5 months ago

Bischoff commented 7 months ago

Here are the CRUD methods related to minidisks handling:

We are missing a Read function for GET /guests/{userid}/disks.

Here is how it appears in the source code of the python client library:

zvmconnector> grep /disks restclient.py -B1

def req_guest_create_disks(start_index, *args, **kwargs):
    url = '/guests/%s/disks'

def req_guest_delete_disks(start_index, *args, **kwargs):
    url = '/guests/%s/disks'

def req_guest_config_minidisks(start_index, *args, **kwargs):
    url = '/guests/%s/disks'

To fix this, I wrote a PR to add the missing API call.

Bischoff commented 5 months ago

PR merged, closing the issue