openmainframeproject / feilong

Feilong is a open source z/VM cloud connector project under the Open Mainframe Project umbrella that will accelerate the z/VM adoption, extending its ecosystem and its user experience. It provides a set of APIs to operate z/VM including guest, image, network, volume etc.
https://www.openmainframeproject.org/projects/feilong
Apache License 2.0
35 stars 70 forks source link

Clarify architecture schema #808

Closed Bischoff closed 5 months ago

Bischoff commented 5 months ago

Fix issue #782

(edited)

The Linux guests managed by feilong were absent from the schema, while they are the final goal. This PR adds them and also shows that they are accessed by IUCV too.

also:

bjhuangr commented 5 months ago

All looks good to me, except: the box on the right is for a Linux guest

I think in original diagram, the box on the right is SMAPI servers. feilong talks to SMAPI request server via IUCV channel.

@jichenjc need your comment as you drawed this :)

jichenjc commented 5 months ago

SMAPI is part of z/VM ==> SMAPI is a set of CMS VM , it's running REXX and provide socket connection , you can use IUCV or TCPIP to connect to the socket server side, so I Think that part is correct ...

Bischoff commented 5 months ago

OK, that was my original question in #782 and also in the discussion for #751.

So let's keep the content of the right box. But there's still something I'd like to correct.

"you can use IUCV or TCPIP to connect to the socket server side" yes, but if I understood well, feilong uses TCP/IP to do that (via zthin). But the schema shows IUCV.

I therefore suggest to redo my work, keeping the box on the right, but changing "IUCV" to "TCP/IP".

Would that work?

jichenjc commented 5 months ago

"you can use IUCV or TCPIP to connect to the socket server side" yes, but if I understood well, feilong uses TCP/IP to do that (via zthin). But the schema shows IUCV.

SMAPI allow TCPIP and IUCV feilong is using IUCV (so we can bypass the setting of z/VM IP, port etc configuration) ,just use IUCV to directly talk to the z/VM that compute node inside is running the feilong

bjhuangr commented 5 months ago

Yes, feilong is using IUCV, not TCP/IP

Bischoff commented 5 months ago

ok, I can do a schema with 3 boxes that summarizes it all:

  1. at the center, BYOS Linux + feilong
  2. at the left, guest Linux + user workflows
  3. at the right, CMS + SMAPI

would that be okay?

jichenjc commented 5 months ago

yes, good change

@bjhuangr thoughts?

bjhuangr commented 5 months ago

ok, I can do a schema with 3 boxes that summarizes it all:

  1. at the center, BYOS Linux + feilong
  2. at the left, guest Linux + user workflows
  3. at the right, CMS + SMAPI
  • between 1. and 2., an IUCV connection
  • between 2. and 3., an IUCV connection too

would that be okay?

Looks good to me. Thanks for refine the diagram.

Bischoff commented 5 months ago

OK, new version is in this PR.

Is it OK?