search

openmainframeproject / feilong

Feilong is a open source z/VM cloud connector project under the Open Mainframe Project umbrella that will accelerate the z/VM adoption, extending its ecosystem and its user experience. It provides a set of APIs to operate z/VM including guest, image, network, volume etc.
https://www.openmainframeproject.org/projects/feilong
Apache License 2.0
36 stars 70 forks source link

fcp_zero_prefix_missing_in_fcp_template_detail_api #816

Closed jackydalong closed 7 months ago

jackydalong commented 7 months ago

for fcp devices (0007, 001A, 020B) with prefix 0, the response of fcp template detail API show them (7, 1A, 20B) without the prefix

The PR is to make the API show those FCP devices by keeping their prefix

bjhuangr commented 7 months ago

the change LGTM, maybe add some UT cases to check?

jackydalong commented 7 months ago

the change LGTM, maybe add some UT cases to check?

UT is added in another PR together @bjhuangr https://github.com/openmainframeproject/feilong/pull/817

jackydalong commented 7 months ago

The PR is covered by another one https://github.com/openmainframeproject/feilong/pull/817