search

openmainframeproject / feilong

Feilong is a open source z/VM cloud connector project under the Open Mainframe Project umbrella that will accelerate the z/VM adoption, extending its ecosystem and its user experience. It provides a set of APIs to operate z/VM including guest, image, network, volume etc.
https://www.openmainframeproject.org/projects/feilong
Apache License 2.0
36 stars 70 forks source link

Add support for comment in user direct #834

Closed santhosh-sloka closed 3 months ago

santhosh-sloka commented 3 months ago

To Support comments in user directory, It is discussed in detail in case " https://github.ibm.com/zvc/planning/issues/18693 "

--signed off : ssanthosh@in.ibm.com

santhosh-sloka commented 3 months ago

Dear @SeanHQF @jichenjc - FYI

@jichenjc - As discussed created a separte PR for the comment support, thanks

jichenjc commented 3 months ago

/lgtm

jichenjc commented 3 months ago

@SeanHQF please review so we can merge this

santhosh-sloka commented 3 months ago

@SeanHQF please review so we can merge this

@jichenjc @SeanHQF - We are testing the existing scenario , will confirm by this week or the merger of PR : https://github.com/openmainframeproject/feilong/pull/834, https://github.com/openmainframeproject/feilong/pull/833 and https://github.ibm.com/zvc/nova-icic/pull/102

SeanHQF commented 3 months ago

Why not combine this with https://github.com/openmainframeproject/feilong/pull/833?

SeanHQF commented 3 months ago

Generally I am ok with the code change, but since the change is small, so may be combined together with clear comment or 2 commits.

jichenjc commented 3 months ago

no, We should not do combination if it's not related 2 commits @SeanHQF that one is for CPU share and this one is for comment?

SeanHQF commented 3 months ago

no, We should not do combination if it's not related 2 commits @SeanHQF that one is for CPU share and this one is for comment?

ok