search

openmainframeproject / software-discovery-tool

Software Discovery Tool
Apache License 2.0
31 stars 40 forks source link

rocky version fixed from 9.0 to 9 #112

Closed aashish-khatri closed 1 year ago

aashish-khatri commented 1 year ago

I've updated the rocky linux api link as requested in issue #103, I would like to know your thoughts on this @arshPratap @pleia2.

arshPratap commented 1 year ago

Lgtm.. Oops looks like there is some authentication issue with email and got account.. U might need to fix that for the checks to clear.. Anyways nicely done. @pleia2 thoughts?

pleia2 commented 1 year ago

Open Mainframe Project projects require DCO sign-off in the commit message, there are instructions on how to fix it here: https://github.com/openmainframeproject/software-discovery-tool/pull/112/checks?check_run_id=13464348220

And to avoid it in the future, when you commit your code you should use: git commit -a --signoff

pleia2 commented 1 year ago

Oops, looks like it got a bit tangled up with the z/OS open tools work. You might want to create branches in git for each issue you're working on (for example: git checkout -b issue/103).

Can you re-create this pull request with just the Rocky Linux 9 change?

aashish-khatri commented 1 year ago

Yeah, actually, I forgot to switch the branch for the new issue and committed to this branch. I will re-create the PR.

aashish-khatri commented 1 year ago

@arshPratap @pleia2 I've corrected the pull request. PTAL. I think the changes are right now.

arshPratap commented 1 year ago

LGTM ! Thanks @aashish-khatri