search

openmainframeproject / software-discovery-tool

Software Discovery Tool
Apache License 2.0
31 stars 40 forks source link

Fixing Creation of Opensuse data Files #156

Closed Princee215 closed 11 months ago

Princee215 commented 12 months ago

As mentioned in #145 issue. All the OpenSUSE data files that are being generated have an empty JSON file, that was due to a buggy code that Arsh and I tried to correct. We use to have separate chunk of code for creation of different files, In this PR I've use nested for loop and try to reduce down the repetition and the lines of code. Once this get a green flag, I'll subsequently update the data files in the data repository that are empty right now.

@pleia2 and @arshPratap please take a look and let me know if there's anything that needs to be done.

arshPratap commented 12 months ago

Thanks @Princee215 ..works really well..just some minor fixes thats all

arshPratap commented 12 months ago

@Princee215 lemme know when you have fixed the changes I have suggested .. I would love to approve this PR @pleia2 would love to hear your thoughts on this . Thanks

Princee215 commented 11 months ago

Sure, thanks @arshPratap, i see these changes. And I'll try to edit as soon as possible.

arshPratap commented 11 months ago

Great Work @Princee215 :+1: