search

openmainframeproject / software-discovery-tool

Software Discovery Tool
Apache License 2.0
31 stars 40 forks source link

zOS Open Tools Automation #187

Closed Apurv428 closed 2 months ago

Apurv428 commented 2 months ago

Fixed issue #110 which was addressed in the PR. I have addressed the changes which were requested on the PR

pleia2 commented 2 months ago

Since @aashish-khatri wrote the code you're basing this PR on, you will need to include his work in your workflow so proper credit is assigned to the author. This is very important :smile:

So instead of just copying it into your PR, you will want to:

  1. Checkout his code from #124 (which includes his commits)
  2. Rebase the code with what is in the master branch (there's a lot of extra changes in your file diffs)
  3. Apply your improvements
  4. Push that back up to this PR, making sure all the commits are included, which give an audit trail to include Aashish's work

Let me know if you need any help!

Apurv428 commented 2 months ago

Since @aashish-khatri wrote the code you're basing this PR on, you will need to include his work in your workflow so proper credit is assigned to the author. This is very important 😄

So instead of just copying it into your PR, you will want to:

  1. Checkout his code from added automation for z/OS open tools #124 (which includes his commits)
  2. Rebase the code with what is in the master branch (there's a lot of extra changes in your file diffs)
  3. Apply your improvements
  4. Push that back up to this PR, making sure all the commits are included, which give an audit trail to include Aashish's work

Let me know if you need any help!

I was unaware that this can be done. I will make the changes. Thanks!

Apurv428 commented 2 months ago

Opened #195 with the required changes