search

openmc-dev / openmc

OpenMC Monte Carlo Code
https://docs.openmc.org
Other
772 stars 498 forks source link

Consistent normalization of Legendre and Zernike polys #1002

Closed lindsayad closed 6 years ago

lindsayad commented 6 years ago

Currently, users have to normalize by (2n + 1) / 2 for Legendre coefficients and similarly by 1 / pi for Zernikes. If we're going to do this, then I think we should also remove the Zernike code that multiplies the Zernike polynomials by √((2n + 2) / epsilon). We should decide: either the user has to apply the integration factors consistently or they don't.

paulromano commented 6 years ago

Yeah, I've been thinking as much recently too. Care to submit a PR making this change? Of the two options (us normalizing vs user normalizing), I would prefer that users do the normalization.

lindsayad commented 6 years ago

Yes, I can submit

On Mon, May 7, 2018 at 3:22 PM, Paul Romano notifications@github.com wrote:

Yeah, I've been thinking as much recently too. Care to submit a PR making this change? Of the two options (us normalizing vs user normalizing), I would prefer that users do the normalization.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mit-crpg/openmc/issues/1002#issuecomment-387210764, or mute the thread https://github.com/notifications/unsubscribe-auth/AJxgcD2aV9GZdCcKKRUPMvbQhVLM4NhQks5twLr_gaJpZM4T1lbf .