search

openmc-dev / openmc

OpenMC Monte Carlo Code
https://docs.openmc.org
Other
772 stars 498 forks source link

Events used to contribute to Zernike filter #1018

Closed paulromano closed 6 years ago

paulromano commented 6 years ago

As @lindsayad discovered the hard way, currently collisions outside of the defined domain for a Zernike polynomial used for a Zernike filter can still contribute to the tally. Effectively, we are fitting polynomials to data that is possibly outside of the defined domain, so I'm going to call that a bug. Fixing should be as easy as only scoring when the normalized radius is <=1.

@lindsayad I'd welcome a PR from you, but if you're too busy I can also fix it myself.

hanzhuoran commented 6 years ago

I believe I fixed this in my PR.