openmc-dev / openmc

OpenMC Monte Carlo Code

https://docs.openmc.org

Other

701 stars 450 forks source link

Changed CI to use latest actions to get away from the Node 16 deprecation. #2912

Closed MicahGale closed 2 months ago

MicahGale commented 2 months ago

Description

This pegs GHA to the latest versions for all actions. See #2905 for more context. To review this the most important thing is to check the CI runs for warnings in the summary.

Fixes #2905

Checklist

[x] I have performed a self-review of my own code
[ ] ~I have made corresponding changes to the documentation (if applicable)~
[ ] ~I have added tests that prove my fix is effective or that my feature works (if applicable)~

MicahGale commented 2 months ago

Another question: do we just pin to @master? This would introduce some risk of an action in the future breaking our workflow, but on the upside, never having to go through this process again really.

paulromano commented 2 months ago

Another question: do we just pin to @master?

I'm personally fine sticking with our current mode of operation. The major updates to these actions don't seem to happen that frequently so updating once in a while as we have been doing is fine IMO.

paulromano commented 2 months ago

@MicahGale if you want to remove the draft status on this PR, I think it's ready to go.

MicahGale commented 2 months ago

@paulromano There's still a dozen docker workflows to update. I was going to make a patch and try applying it to all docker files and see how that goes.

MicahGale commented 2 months ago

@paulromano on next release could you remember to check for any warning logs in the deploy CI?

shimwell commented 2 months ago

I noticed we make use of coverallsapp/github-action@master near the bottom of in the Ci.yml and this results in a node 16 warning.

perhaps this could also be updated to version 2.2.3 or simply 2

https://github.com/coverallsapp/github-action

MicahGale commented 2 months ago

So the issue here is that coveralls has a main and master branch, and only deploys to main. So I think using a specific version will be more consistent.