openmc-dev / openmc

OpenMC Monte Carlo Code
https://docs.openmc.org
Other
699 stars 444 forks source link

Update xtl and xtensor submodules #2941

Closed HunterBelanger closed 3 weeks ago

HunterBelanger commented 4 weeks ago

Description

This PR updates the xtl and xtensor submodules to be the most recent tagged version of each. This change is motivated by #2919, where I found that the versions that we are currently using appear to have a memory bug in Windows. These more recent versions do not seem to pose any issues for me on linux or Windows.

While this PR currently just updates the submodules, it might also be a good time to discuss possibly moving from submodules to FetchContent. This is a new feature which was added to CMake 3.11 (currently we require 3.10+), which allows you to specify git repos in the CMakeLists file, and then CMake will automatically clone them and set them up on build. I personally find it much easier to work with, and it also avoids the problem of initializing the submodules, and updating versions is just a simple change in the CMakeLists.

Checklist