Right now, if you are exporting a model and ask it to remove redundant surfaces (Geometry.merge_surfaces = True), it compares the surface type and coefficients to determine whether two surfaces are considered equivalent. However, the boundary_type is not currently accounted for, which can cause problems if you have one surface with a boundary condition applied and another surface with no BC that is used on a lower universe level. This PR simply makes a change to account for the boundary_type when determining whether two surfaces are equivalent.
Checklist
[x] I have performed a self-review of my own code
[x] I have run clang-format (version 15) on any C++ source files (if applicable)
[x] I have followed the style guidelines for Python source files (if applicable)
[x] I have made corresponding changes to the documentation (if applicable)
[x] I have added tests that prove my fix is effective or that my feature works (if applicable)
Description
Right now, if you are exporting a model and ask it to remove redundant surfaces (
Geometry.merge_surfaces = True), it compares the surface type and coefficients to determine whether two surfaces are considered equivalent. However, theboundary_typeis not currently accounted for, which can cause problems if you have one surface with a boundary condition applied and another surface with no BC that is used on a lower universe level. This PR simply makes a change to account for theboundary_typewhen determining whether two surfaces are equivalent.Checklist
I have run clang-format (version 15) on any C++ source files (if applicable)I have made corresponding changes to the documentation (if applicable)