openmc-dev / openmc

OpenMC Monte Carlo Code
https://docs.openmc.org
Other
699 stars 444 forks source link

make uwuw optional #2965

Closed LukeLabrie closed 1 week ago

LukeLabrie commented 2 weeks ago

Description

This PR allows for OpenMC to be configured with a version of DAGMC that was built without UWUW (University of Wisconsin Unified Workflow). This was useful for me in order to bypass the PyNE dependency.

Currently I've just added a new cmake variable, and separated out the uwuw-related methods in dagmc.cpp so they can be handled accordingly by the preprocessor.

Checklist

shimwell commented 2 weeks ago

Wow this is an interesting PR. Do you happen to have any info on the time saved when compiling openmc without UWUW or the reduction in memory footprint of the resulting executable.

I would be keen to follow up this PR and add without UWUW as an option to the conda package as well. I'm thinking this might make resolving conda environments easier as I still have trouble installing openmc, cadquery, moab and gmsh in a single environment.

LukeLabrie commented 2 weeks ago

@shimwell, so it saves me about a minute of compile time on DAGMC (single-thread), but does not appreciably change the compile time for openmc.

the executable is only ~2kb smaller for me

gridley commented 2 weeks ago

Nice. Not sure if intentional, but it always reminded me of this:

https://en.wikipedia.org/wiki/Uwu