search

openmc-dev / openmc

OpenMC Monte Carlo Code
https://docs.openmc.org
Other
772 stars 500 forks source link

Move to C++17 for std::filesystem #3041

Open drewejohnson opened 4 months ago

drewejohnson commented 4 months ago

Following up from #3035, I found a couple references to using the filesystem library for C++17.

https://github.com/openmc-dev/openmc/blob/5222b343a4e7f21fa64d0d6be92292878e1f6ae3/include/openmc/file_utils.h#L8

https://github.com/openmc-dev/openmc/blob/5222b343a4e7f21fa64d0d6be92292878e1f6ae3/src/cross_sections.cpp#L309

Is the intent to see if file_utils.h can be removed wholesale from the library? Or to at least heavily rely on std::filesystem?

paulromano commented 4 months ago

Yes, if we don't need to reinvent the wheel, that would be much preferred!