search

openmc-dev / plotter

Native plotting GUI for model design and verification
MIT License
43 stars 17 forks source link

Pyside6 upgrade #127

Closed eepeterson closed 6 months ago

eepeterson commented 8 months ago

I just wanted to get this process started since I too was running into some Python 3.11 issues with the plotter. I've done some testing with this PR and things seem to work fine although my testing has been pretty sparse so far. FWIW I got this working locally by specifying the environment variable QT_QPA_PLATFORM_PLUGIN_PATH to point to the Qt installation included with PySide6. I don't yet know the best way to facilitate this for the user since I think matplotlib will also install its own version of Qt? Maybe figuring out how to specify that version in the openmc install so that it's compatible with PySide6 and in the plotter install directing it to the Qt installation included with matplotlib? No idea, but open to suggestions.

eepeterson commented 7 months ago

thanks for the added commits @paulromano! Could you post a short description for posterity about the added packages and why they're necessary for this project?

pshriwise commented 6 months ago

@paulromano @eepeterson Do we want to get this in before the next release? This would support the plotter for Python <3.13, >=3.8. Given that the oldest version of Python we test with for OpenMC is 3.7 (which is essentially EOL) I think it makes sens to ditch PySide2 fully and move on to PySide6 with these changes in the next release. Thoughts?

paulromano commented 6 months ago

@eepeterson Sorry for neglecting this. The start-stop-daemon line I got from here. All the other changes in ci.yml were just trial and error and were based on errors that I was seeing in CI about libraries missing, so I just added things one at a time until it worked.

@pshriwise See my comment in #130 about timing. I'd prefer we do one more Pyside2-based release and then merge this after.

eepeterson commented 6 months ago

no worries - all sounds good to me.

pshriwise commented 6 months ago

Now that v0.3.2 is out, I think this is good to merge. Any objections @pshriwise?

None here 🚀