search

openmc-dev / plotter

Native plotting GUI for model design and verification
MIT License
46 stars 18 forks source link

GHA Updates #60

Closed pshriwise closed 3 years ago

pshriwise commented 3 years ago

This adds a CI file to run the single test we have on CI for PRs into develop and master.

It also updates one of the PyPI scripts to no longer trigger on the develop branch. PyPI requires a new version each time it is run, so it doesn't make sense to run it for every PR merge. If there's a better way to handle that @Shimwell, let us know!

shimwell commented 3 years ago

Looks great, extra nice to see those OpenMC dockerhub images being used.

I noticed you are using openmc/openmc:v0.12.1 which is the latest release. Wondering if you want to tag the latest release version instead so it is pointing to the newest version automatically.

pshriwise commented 3 years ago

Yeah I suppose that for development we should make sure we're compatible with the development version of OpenMC. If I'm understanding correctly that is.