search

openmediavault / openmediavault

openmediavault is the next generation network attached storage (NAS) solution based on Debian Linux. Thanks to the modular design of the framework it can be enhanced via plugins. openmediavault is primarily designed to be used in home environments or small home offices.
https://www.openmediavault.org
Other
4.84k stars 458 forks source link

Fix VirtualBox support #1755

Closed Forage closed 1 month ago

Forage commented 2 months ago

The VirtualBox provider did not work as is.

As far as I can tell, the issue addressed with patch.sh only applied to libvirt anyway. The way disk were added caused issues like https://github.com/hashicorp/vagrant/issues/8107. The only 'drawback' of the new way of adding the disks is that they are put in the default VirtualBox location instead of the disks folder with the Vagrantfile file.

CLAassistant commented 2 months ago

CLA assistant check
All committers have signed the CLA.

votdev commented 1 month ago

Is the patching not necessary on a VirtualBox installation?

votdev commented 1 month ago

The signed-off-by line is missing in the commit message. Please check https://github.com/openmediavault/openmediavault/blob/master/CONTRIBUTING.md how to contribute a PR.

Forage commented 1 month ago

Is the patching not necessary on a VirtualBox installation?

I have the following on a new VB setup, without the patch: image

I can connect to the GUI without issues without the patch. These two devices is what you are after, wasn't it?

The IP address is the only additional thing I manually changed in the Vagrantfile, since the IP range did not correspond to the default range allowed by VB.

If I keep the patch, the machine will boot, but Vagrant is no longer able to cleanly finish its setup after the reload.

Forage commented 1 month ago

The signed-off-by line is missing in the commit message. Please check https://github.com/openmediavault/openmediavault/blob/master/CONTRIBUTING.md how to contribute a PR.

I couldn't fix the commit message while keeping the existing PR. New PR #1756.

ryecoaaron commented 1 month ago

All you have to do is append the commit and force push.

Forage commented 1 month ago

All you have to do is append the commit and force push.

Tried that, did not work. Github did not allow me to reopen the PR.

votdev commented 1 month ago

Is the patching not necessary on a VirtualBox installation?

I have the following on a new VB setup, without the patch: image

I can connect to the GUI without issues without the patch. These two devices is what you are after, wasn't it?

The IP address is the only additional thing I manually changed in the Vagrantfile, since the IP range did not correspond to the default range allowed by VB.

If I keep the patch, the machine will boot, but Vagrant is no longer able to cleanly finish its setup after the reload.

The problem is the naming of the network devices. ethX is not predictable, that's why the patch is applied. The names should look like ensX.