Closed gromeck closed 1 month ago
Insertion of a sequence like " " arises the question, if passed parameters are well checked in the workbench -- but this is a different story.
Such complex input fields are not validated because checking this via regex will end in an disaster.
openmediavault allows to configure rsync jobs which are executed via cron (nice!). rsync allows to pass multiple source directories and files in the form:
rsync will process all given sources in the job -- openmediavault doesn't support this parameter handling, except you use an ugly workaround.
To Reproduce
Services
-Rsync
-Tasks
(+)
local
pull
root@<yourserver.here>:/etc :/home
<your local folder>
Public Key
22
<your-ssh-cert>
Save
this new taskApply
pending configuration changesRun
Expected behavior
The rsync cronjob should process all given source directories and files.
openmediavault Server:
Client:
n/a
Workaround
The problem is located in
/openmediavault/deb/openmediavault/srv/salt/omv/deploy/rsync/files/cron-rsync-script.j2
, line 77:The source is passed in double quotes to rsync which then processes these as one command line argument.
The workaround (see the steps to reproduce above) is to seperate the different arguments for Source server not only with a single blank, but with
" "
:Source server=
root@<yourserver.here>:/etc" ":/home
This looks weird and ugly -- but works for now.
Additional context
Insertion of a sequence like
" "
arises the question, if passed parameters are well checked in the workbench -- but this is a different story.