openmedicus / gtk-sharp

DEPRECATED: Use https://github.com/GLibSharp/GtkSharp or https://github.com/GtkSharp/GtkSharp
Other
22 stars 6 forks source link

ColorChooserDialog no RGBA property #11

Closed harry-cpp closed 8 years ago

harry-cpp commented 8 years ago

ColorChooserDialog doesn't generate RGBA property, instead it generates GetRGBA and SetRGBA methods, but GetRGBA(Gdk.RGBA rgba) doesn't even have a return value.

harry-cpp commented 8 years ago

Same goes for ColorChooserWidget

mikkeljohnsen commented 8 years ago

I have just made a push that uses GdkRGBA in Gtk. Could you please test if it works ?

I see in this pull request you use "val.Val" and the generated code I have just pushed don't. So please get back to me if it doesn't work.

harry-cpp commented 8 years ago

This was not fixed :(

harry-cpp commented 8 years ago

Ups, wrong button, silly me...

mikkeljohnsen commented 8 years ago

So, it is not working ?

Maybe the cast "Gdk.RGBA ret = (Gdk.RGBA) val;" must be "Gdk.RGBA ret = (Gdk.RGBA) val.Val";

harry-cpp commented 8 years ago

So, it is not working ?

It's still generating GetRGBA and SetRGBA instead of a property and GetRGBA is still not working.

mikkeljohnsen commented 8 years ago

Yes, I removed the property, because it did not compile with it. I will see if I can get it to generate the code properly. It generates it correctly with the "use-alpha" property.

harry-cpp commented 8 years ago

Yes, I removed the property, because it did not compile with it. I will see if I can get it to generate the code properly. It generates it correctly with the "use-alpha" property.

You could also stop generating GetRGBA and SetRGBA and manually implement the RGBA property in the class.

mikkeljohnsen commented 8 years ago

Could you test the latest push ?

harry-cpp commented 8 years ago

Works great, thank you very much for maintaining gtk sharp 3!!!