openmessaging / benchmark

OpenMessaging Benchmark Framework
Apache License 2.0
385 stars 237 forks source link

Add maven exclusion for netty transitive dependency in artemis #376

Closed skykistler closed 1 year ago

skykistler commented 1 year ago

Fixes issue noted in https://github.com/openmessaging/benchmark/issues/363 , which was blocking me in production as well as locally

Currently the benchmark-framework module is unable to create the worker pool when given a list of workers due to a transitive dependency on netty-transport==4.1.77.Final which is pulled in from the artemis client, which conflicts with asynchttpclient's dependency on netty

This excludes all netty dependencies that the artemis library pulls in which resolves the issue. The artemis driver seems to be functional still without this transitive dependency.

You can reproduce this issue locally by starting benchmark-worker and attempting to run any benchmark using those workers. Adding the exclusion and rebuilding allows the benchmark to work as intended.

This also seems to resolve an issue I was encountering where the benchmark will fail to terminate the java process once it completes. The bin/benchmark executable now terminates successfully upon completion.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 5 days if no further activity occurs. Thank you for your contributions.

skykistler commented 1 year ago

@merlimat @teabot Thank you for any attention to this