openmethane / openmethane-prior

Method to calculate a gridded, prior emissions estimate for methane across Australia
Apache License 2.0
4 stars 0 forks source link

adding unit and name attributes to layers #36

Closed prayner closed 3 months ago

prayner commented 3 months ago

addresses #16


Description

Checklist

Please confirm that this pull request has done the following:

Notes

prayner commented 3 months ago

added the attributes, I'll leave the test to someone who understands pytest

lewisjared commented 3 months ago

@prayner Are you able to see any line-specific comments or are they not available in emacs?

prayner commented 3 months ago

Don't think I can see them in emacs ... let's see if the gh cli reveals them

prayner commented 3 months ago

I'm not seeing in-line comments, are there some here?

lewisjared commented 3 months ago

@prayner Can I add the tests to this branch? If so please assign this PR to me