openmethane / openmethane-prior

Method to calculate a gridded, prior emissions estimate for methane across Australia
Apache License 2.0
4 stars 0 forks source link

Run om prior #8

Closed crdanielbusch closed 5 months ago

crdanielbusch commented 5 months ago

Description

Checklist

Please confirm that this pull request has done the following:

Notes

@prayner When we check the data with omPriorVerify.py, we get the following output. Does that still work?

PASSED - Livestock CH4 within bounds of total agriculture CH4: 0.16963856
FAILED - Discrepency of -51.030272990142386% in agriculture emissions
FAILED - Discrepency of -65.28372899999995% in electricity emissions
FAILED - Discrepency of -89.48823911165206% in fugitive emissions
FAILED - Discrepency of -73.59460500000147% in industrial emissions
FAILED - Discrepency of -77.15502137254902% in lulucf emissions
FAILED - Discrepency of -73.59460972972967% in stationary emissions
FAILED - Discrepency of -73.59461375000018% in transport emissions
FAILED - Discrepency of -79.06976740181267% in waste emissions
prayner commented 5 months ago

I tried to send links to 10km versions of these files yesterday, clearly that didn't work. You can find these at https://www.dropbox.com/scl/fi/h8quykmt9u16ggmmv8zjr/GRIDDOT2D_2?rlkey=sr5ka3rjp8y3vkew8r2lln6zb&dl=0 https://www.dropbox.com/scl/fi/hyd7tdk3ows3asytzxl4y/GRIDCRO2D_2?rlkey=jn2kj9lxtkycsfeat1atx1m4w&dl=0 The geo_em file is produced by the wps process before running WRF, the GRID* files are produced in the MCIP process run as part of the setupCMAQinputs script and is generated from the wrfout files. They're pretty similar except that the GRID files have some edge gridcells removed since the meteorology here is less reliable. I'd be very surprised if the code will run with different resolutions.

crdanielbusch commented 5 months ago

Thanks for sending the files @prayner. I have added them to the repository.

The tests in omPriorVerify.py now pass.

lewisjared commented 5 months ago

Great! We should refactor the verify script into something that can be tested in a future MR

prayner commented 5 months ago

I'm wary of including the GRID* files in the repo since they're not really input files nor are they part of the prior process itself but are used to create om-domain-info.nc. Can we perhaps include om-domain-info.nc itself?

prayner commented 5 months ago

In my normal workflow om-domain-info is produced from the GRID files then the GRID files are not used again. If omCreatDomainInfo runs successfully we should (a) have consistent grids and (b) not need the GRID* files again. If the prior is only being developed for Open Methane then none of this matters much. -- Peter Rayner (he/him), Honorary Professorial Fellow, University of Melbourne mobile +61 402 752 379 zoom id 4431343191, join at https://unimelb.zoom.us/j/4431343191?pwd=a1E5Z3JEOTRVQUJsaVdRbVUvR1QyZz09 mail-to: @.*** google scholar: https://scholar.google.com.au/citations?user=H3up71wAAAAJ&hl=en I acknowledge the Traditional Custodians of the land on which I work, the Wurundjeri people of the Kulin nation, and pay my respect to their Elders, past and present I am sending this email when convenient for me, please only respond when convenient for you