search

openmetrics-php / exposition-text

Implementation of the text exposition format of OpenMetrics
MIT License
29 stars 8 forks source link

Update LabelCollection.php #10

Closed Jake6199 closed 5 months ago

Jake6199 commented 1 year ago

Deprecated: Return type of OpenMetricsPhp\Exposition\Text\Collections\LabelCollection::getIterator(): Traversable |array should either be compatible with IteratorAggregate::getIterator(): Traversable

Fixes #8

Proposed Changes

make the getIterator() Traversable instead of Iterable

Further comments

PabloKowalczyk commented 6 months ago

@hollodotme friendly ping, any chance for review and merge?

hollodotme commented 5 months ago

@PabloKowalczyk Working on it today and will probably release it today, too.

hollodotme commented 5 months ago

Closing. The fix will be included in #13.

PabloKowalczyk commented 5 months ago

Nice, thanks @hollodotme