search

openmetrics-php / exposition-text

Implementation of the text exposition format of OpenMetrics
MIT License
29 stars 8 forks source link

Remove space between labels #14

Closed jaapio closed 3 months ago

jaapio commented 3 months ago

According to spec labels are separated by a comma, without any whitespace. To show this behavior we changed the integration test to have one case with 2 labels. This makes the integrationtest fail.

We are using the withLabels method twice because their is an incompatibility between php 7.3 and 7.4 vardict arguments are different ordered between those versions. By calling the method twice we can make sure the order is kept.

hollodotme commented 3 months ago

@jaapio Thanks for spotting this. 💪 It's not that obvious in the spec.

I'll merge it and release v0.4.1.

hollodotme commented 3 months ago

✅ v0.4.1 was released.

jaapio commented 3 months ago

Thanks for merging and releasing!