search

openmetrics-php / exposition-text

Implementation of the text exposition format of OpenMetrics
MIT License
29 stars 8 forks source link

8.1 Deprecation notice(s) #8

Closed mgrundkoetter closed 5 months ago

mgrundkoetter commented 1 year ago

Expected Behavior

Should work on PHP 8.1+ :-)

Actual Behavior

Deprecated: Return type of OpenMetricsPhp\Exposition\Text\Collections\LabelCollection::getIterator(): iterable should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/html/vendor/openmetrics-php/exposition-text/src/Collections/LabelCollection.php on line 65

There are probably some more.

Steps to Reproduce the Problem

  1. Use lib with PHP 8.1
  2. do something with labels
  3. recognize deprecation warning

Specifications

Further comments

m-nic commented 8 months ago

Hi, Same issue is encountered on several classes for php 8.3. Is this repo abandoned?

hollodotme commented 8 months ago

It's not abandoned. There is just not enough time on my end at the moment. Any help - in the meaning of a Pull Request Contribution - is welcome. 🙏

m-nic commented 8 months ago

It's not abandoned. There is just not enough time on my end at the moment. Any help - in the meaning of a Pull Request Contribution - is welcome. 🙏

See: https://github.com/openmetrics-php/exposition-text/pull/11

hollodotme commented 5 months ago

Will be fixed with #13