openmina / mina-p2p-messages-rs

0 stars 0 forks source link

As a Developer, I need to have extensive CI for Mina messages codecs, so I can see errors/regressions #20

Open akoptelov opened 1 year ago

akoptelov commented 1 year ago

Definition of Done: working CI pipelines and reports (see below)

akoptelov commented 1 year ago

I'll try to set this up using Github Actions as much as possible.

akoptelov commented 1 year ago

Here are some ideas/thoughts on the testing for messages (also applicable to other components).

Problems to be targeted by the tests (note that this is for both native and wasm32):

Here are some additional requirements:

There are some issues here:

akoptelov commented 1 year ago

See the allocations and performance benchmarks for messages (gossip messages and RPC catchup sequence). Native tests: https://github.com/name-placeholder/mina-p2p-messages-rs/actions/runs/3346769732/jobs/5543986463 Wasm tests (with the perf one failing because of flakiness): https://github.com/name-placeholder/mina-p2p-messages-rs/actions/runs/3346769732/jobs/5543986587

Performance tests lib should be updated a bit, now the regression detection is incorrect (based only on mean value), and stdev value is not displayed.