search

openmindanesth / openmind

anesthetic database
Eclipse Public License 1.0
1 stars 1 forks source link

delete extracts #76

Closed hlesaint closed 4 years ago

hlesaint commented 4 years ago

Well, yes, difficult issue. I think it should not be possible. Maybe I just send you a list of extracts to delete?

"This is a new extract. It has been edited." could be deleted.

Is there a possibility that the extracts affected in #75 are corrupt?

tgetgood commented 4 years ago

We could implement it as a "soft delete" where the extract is removed from the search index, so that it never comes up in results, but we keep it otherwise, so that if you have a link to it, you can still see it, and we can restore it if desired. We would have to choose whether to keep relations or not if we took this approach.

Alternately, I can give deletion privileges to a small group of admins, and leave it at that.

hlesaint commented 4 years ago

I think a soft delete is a good idea. Relations should be gone and restored with the extract.

For me it would be perfectly fine to once in a while send you a request for deleting a particular extract. I believe this should be happening very rarely.

The mentioned extract, for instance, was only a test, it cannot be edited and looks a bit weird when we start to invite contributors. This would be the only one I'd ask you to delete for now:

"This is a new extract. It has been edited."

tgetgood commented 4 years ago

I've set up the soft delete code. Just send me the url from the edit page of the extracts you think should be deleted in the future.

It would be a good idea to open an issue for each set of deletions so that we have a record in case we decide we want to undelete something later on.