search

openminted / Open-Call-Discussions

A central place for participants in the open calls to ask questions
2 stars 1 forks source link

Expose Workflow Service Status Messages #17

Closed greenwoodma closed 6 years ago

greenwoodma commented 6 years ago

At the moment it's difficult for a user of the platform to know why a workflow has failed or is stuck forever in the running state -- it's also difficult for us to debug such issues.

The workflow service adds useful information when errors occur to the status messages that are passed back to the registry (including when the status is set to failed). Could these messages be concatenated together and provided as a poor mans version of a log file. Should be easy to implement as the other alternative is some more central logging system which would be more time consuming to add to the platform at this late stage.

greenwoodma commented 6 years ago

another option would be to configure the docker images that run the components in such a way that we capture syslog and return that to the registry. @saxtouri is this feasible

gkirtzou commented 6 years ago

@greenwoodma from what I can see both the workflow service (https://github.com/openminted/omtd-workflow-service/blob/master/src/main/java/eu/openminted/workflow/service/WorkflowServiceImpl.java#L500) and the registry backend (https://github.com/openminted/omtd-registry/blob/develop/src/main/java/eu/openminted/registry/messages/OperationHandler.java#L254) do handle failed cases with error messages. Probably the UI needs to display this information.

greenwoodma commented 6 years ago

Sorry @gkirtzou poor choice of words on my part. Yes I meant we need the platform UI to expose the error messages to the user; for some reason I keep saying registry when I actually mean the UI.

@smartziou is this something you could look at adding?

antleb commented 6 years ago

Please use redmine for internal issue reporting. Lets keep this project for the public.

greenwoodma commented 6 years ago

@antleb normally I'd agree, but this came out of numerous publicly reported issues, and hence it would be useful to track the progress of fixing this publicly as well so that participants can see when more logging info etc. becomes available to them.

greenwoodma commented 6 years ago

Closing this as we've now added more error reporting into the workflow service and this seems to be showing up in the UI when workflows fail (more feedback from deeper into the execution would be nice but I think we have enough now to handle most cases).