search

openminted / Open-Call-Discussions

A central place for participants in the open calls to ask questions
2 stars 1 forks source link

BOLSTM hackathon #32

Closed AndreLamurias closed 6 years ago

AndreLamurias commented 6 years ago

Although we already got some clarification (#26) it would be great to have some assistance in testing our component as part of an application.

gkirtzou commented 6 years ago

The only place to add this information is in the description, right? I was looking for a specific field in the form but couldn't find it.

In the metadata model, we have a model for both raw and annotated corpora, but for the moment from the UI when we create a corpus either from the platform or when we upload on, we make the hypothesis that the corpus is raw, so the metadata for raw corpus is provided in the forms.

I've added the deliverables to the github repo and I will add it as documentation when I upload a new version of the component.

New version from the metadata perspective you mean?

Right now I cannot add BOLSTM to a workflow, it doesn't appear in the workflow editor, even if I start a new application. However it does appear on "My components" and it's public.

Ok, that's weird. I checked and you are right. I does not available in the workflow editor. Though the galaxy wrapper is correctly created. I will check with my collegues to see what's going on.

AndreLamurias commented 6 years ago

New version from the metadata perspective you mean?

I meant new version of the docker image, but if you think it's worth submitting a new version just to include that update to the metadata I can do it

gkirtzou commented 6 years ago

If you want to add the deliverables in the metadata as documentation you would need to re-register. But it is not mandatory.

When you say a new image you mean with the same tag, right? If that's the case let me know when you change the image, to repull it.

On Mon, 14 May 2018, 18:59 André Lamúrias, notifications@github.com wrote:

New version from the metadata perspective you mean?

I meant new version of the docker image, but if you think it's worth submitting a new version just to include that update to the metadata I can do it

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openminted/Open-Call-Discussions/issues/32#issuecomment-388869649, or mute the thread https://github.com/notifications/unsubscribe-auth/AICS7zLIRZ58QaBcvj79m4GgSHuQ4tPxks5tyanigaJpZM4TTNWW .

AndreLamurias commented 6 years ago

When you say a new image you mean with the same tag, right? If that's the case let me know when you change the image, to repull it.

no, I meant a new image with a tag like v1.0.1 or v1.1.0., otherwise I would have to submit the component again and ask you to remove the previous version

gkirtzou commented 6 years ago

@AndreLamurias I believe that your component now appears in the workflow editor. I would suggest editing the application so that you would add correctly the component that now has appeared in editor. Please keep the app private until you have fully tested.

Also add in the app metadata yourself as resourceCreator, as I suggested previously. Let me know how it goes.

AndreLamurias commented 6 years ago

@gkirtzou I got "There was a problem running the application. Try again in a while. (final workflow state is in error)" this is the corpus: https://services.openminted.eu/landingPage/corpus/472a3e95-31c3-43b6-9ade-48edd75db377 application: https://services.openminted.eu/landingPage/corpus/472a3e95-31c3-43b6-9ade-48edd75db377

the workflow only has two components (omtd importer and bolstm) since the corpus is already in the required format. am I missing somethig?

btw this is metadata for the application, with the resourceCreator field as suggested: 4e806362-fb26-403f-ae9e-9716fa5f2cef.zip

gkirtzou commented 6 years ago

1) The metadata of your application are almost ok. Just change the value of identifier to the BOLSTM component in the hasPart relations to "f2ef9b8f-d4bf-4cdd-8380-c7e63f1a0dc2". (That is the correct one, it can be found in the url of the component).

2) I couldn't find any log from your run. It seems that it didn't run at all. So I tried once myself. I created an application (omtdImporter + BOLSTM) as yourself and I uploaded the sample corpus you provided during the test phase. I was able to ran it, but I got the following error in the log

parse-options: unrecognized option '--param:model=full_model'

What are you expecting as parameter?

AndreLamurias commented 6 years ago

What are you expecting as parameter?

Sorry, it was expecting "params" instead of "param". I've fixed it now and pushed to the same tag. I think there's no point in keeping the old version since it just doesn't run on OMTD.

gkirtzou commented 6 years ago

Ok. When you fix the image, reuploaded to the same tag and let me know when it is up, so I re-pull it. Then you can test again.

AndreLamurias commented 6 years ago

@gkirtzou I've reuploaded to the same tag, so let me know if your test goes well and then I'll try again with the application I created

gkirtzou commented 6 years ago

Ok, I have pull the new image. I ran the test correctly and I got the attached results. 1) could you verify the output? 2) Could you also run with your own application? (let me know when you set it to run) full_model_tmpresults.txt.zip

AndreLamurias commented 6 years ago
  1. the OP is correct
  2. I was able to run my application, but I can't download the output. this is the lexical resource produced: https://services.openminted.eu/landingPage/lexical/371bf7ac-7898-4e64-b65b-eaeacbb32005 there's no download button. is this on purpose?
gkirtzou commented 6 years ago

For the moment yes. We are looking into change that policy. So we have a successful run. If you make the suggestions to the metadata you could make it public.

On Thu, 17 May 2018, 17:38 André Lamúrias, notifications@github.com wrote:

  1. the OP is correct
  2. I was able to run my application, but I can't download the output. this is the lexical resource produced: https://services.openminted.eu/landingPage/lexical/371bf7ac-7898-4e64-b65b-eaeacbb32005 there's no download button. is this on purpose?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openminted/Open-Call-Discussions/issues/32#issuecomment-389889820, or mute the thread https://github.com/notifications/unsubscribe-auth/AICS71NNZnSQAFb4jUAM-ipvtMHMulHgks5tzYtogaJpZM4TTNWW .

gkirtzou commented 6 years ago

Here is the results from your experiment as well. As I said yesterday, please proceed fixing the suggestions I made to the metadata of the application and corpus and then make them public. Let me know when you are done.

full_model_tmpresults.zip

AndreLamurias commented 6 years ago

Here's the metadata of the application and corpus, I updated the description of the corpus to include the information about the annotations, and correct component ID on the application metadata. corpus-472a3e95-31c3-43b6-9ade-48edd75db377.zip application-4e806362-fb26-403f-ae9e-9716fa5f2cef.zip

I've made both the application and corpus public

gkirtzou commented 6 years ago

Perfect! We have the component, the corpus and the app in the registry public with good metadata. The apps runs perfectly, so there is nothing else to do. So I am closing the issue. Cheers!