openml / OpenML

Open Machine Learning
https://openml.org
BSD 3-Clause "New" or "Revised" License
668 stars 91 forks source link

upload run with subcomponents #118

Closed dominikkirchhoff closed 7 years ago

dominikkirchhoff commented 10 years ago
<?xml version="1.0"?>
<oml:run xmlns:oml="http://openml.org/openml">
  <oml:task_id>4</oml:task_id>
  <oml:implementation_id>661</oml:implementation_id>
  <oml:parameter_setting>
    <oml:name>bw.iters</oml:name>
    <oml:value>100</oml:value>
  </oml:parameter_setting>
  <oml:parameter_setting>
    <oml:name>xval</oml:name>
    <oml:value>0</oml:value>
    <oml:component>rpart</oml:component>
  </oml:parameter_setting>
  <oml:parameter_setting>
    <oml:name>minsplit</oml:name>
    <oml:value>20</oml:value>
    <oml:component>rpart</oml:component>
  </oml:parameter_setting>
</oml:run>

I get an "Internal Server Error" when trying to upload this. Any ideas? When I uploaded the implementation, I wasn't sure what the component's identifier is supposed to be, are there any restrictions?

This is the flow:

http://openml.liacs.nl/f/661

and this is the subcomponent:

http://openml.liacs.nl/f/662

dominikkirchhoff commented 9 years ago

This issue is still present. I just tested it with another bagged learner that has one subcomponent. As soon as I change one of the subcomponent's parameters, I'm not able to upload the run anymore.

dominikkirchhoff commented 9 years ago

Now I can't even upload a flow with a component anymore... although nothing changed as far as I can see.

This is the XML. I uploaded it a couple of times without any problems, but for the last few days it doesn't work anymore.

<oml:implementation xmlns:oml="http://openml.org/openml">
  <oml:name>classif.J48.bagged</oml:name>
  <oml:external_version>0.4-23</oml:external_version>
  <oml:description>Learner classif.J48.bagged from package(s) RWeka.</oml:description>
  <oml:language>English</oml:language>
  <oml:dependencies>mlr_2.3, RWeka_0.4.23</oml:dependencies>
  <oml:parameter>
    <oml:name>bw.iters</oml:name>
    <oml:data_type>integer</oml:data_type>
    <oml:default_value>10</oml:default_value>
  </oml:parameter>
  <oml:parameter>
    <oml:name>bw.replace</oml:name>
    <oml:data_type>logical</oml:data_type>
    <oml:default_value>TRUE</oml:default_value>
  </oml:parameter>
  <oml:parameter>
    <oml:name>bw.size</oml:name>
    <oml:data_type>numeric</oml:data_type>
  </oml:parameter>
  <oml:parameter>
    <oml:name>bw.feats</oml:name>
    <oml:data_type>numeric</oml:data_type>
    <oml:default_value>0.666666666666667</oml:default_value>
  </oml:parameter>
  <oml:source_md5>6d9797a1c0c2a8641957caab766ec4f9</oml:source_md5>
  <oml:component>
    <oml:identifier>J48</oml:identifier>
    <oml:implementation>
      <oml:name>classif.J48</oml:name>
      <oml:external_version>0.4-23</oml:external_version>
      <oml:description>Learner classif.J48 from package(s) RWeka.</oml:description>
      <oml:language>English</oml:language>
      <oml:dependencies>mlr_2.3, RWeka_0.4.23</oml:dependencies>
      <oml:parameter>
        <oml:name>U</oml:name>
        <oml:data_type>logical</oml:data_type>
      </oml:parameter>
      <oml:parameter>
        <oml:name>O</oml:name>
        <oml:data_type>logical</oml:data_type>
      </oml:parameter>
      <oml:parameter>
        <oml:name>C</oml:name>
        <oml:data_type>numeric</oml:data_type>
        <oml:default_value>0.25</oml:default_value>
      </oml:parameter>
      <oml:parameter>
        <oml:name>M</oml:name>
        <oml:data_type>integer</oml:data_type>
        <oml:default_value>2</oml:default_value>
      </oml:parameter>
      <oml:parameter>
        <oml:name>R</oml:name>
        <oml:data_type>logical</oml:data_type>
      </oml:parameter>
      <oml:parameter>
        <oml:name>N</oml:name>
        <oml:data_type>integer</oml:data_type>
        <oml:default_value>3</oml:default_value>
      </oml:parameter>
      <oml:parameter>
        <oml:name>B</oml:name>
        <oml:data_type>logical</oml:data_type>
      </oml:parameter>
      <oml:parameter>
        <oml:name>S</oml:name>
        <oml:data_type>logical</oml:data_type>
      </oml:parameter>
      <oml:parameter>
        <oml:name>L</oml:name>
        <oml:data_type>logical</oml:data_type>
      </oml:parameter>
      <oml:parameter>
        <oml:name>A</oml:name>
        <oml:data_type>logical</oml:data_type>
      </oml:parameter>
      <oml:parameter>
        <oml:name>J</oml:name>
        <oml:data_type>logical</oml:data_type>
      </oml:parameter>
    </oml:implementation>
  </oml:component>
</oml:implementation>
joaquinvanschoren commented 9 years ago

Hi Jan,

How are things in Porto? Can you take a quick look whether the server is still ok? I can only look at it tomorrow at the earliest.

Thanks! Joaquin

On Tue Jan 20 2015 at 11:15:58 AM dominikkirchhoff notifications@github.com wrote:

Now I can't even upload a flow with a component anymore... although nothing changed as far as I can see.

This is the XML. I uploaded it a couple of times without any problems, but for the last few days it doesn't work anymore.

oml:nameclassif.J48.bagged/oml:name oml:external_version0.4-23/oml:external_version oml:descriptionLearner classif.J48.bagged from package(s) RWeka./oml:description oml:languageEnglish/oml:language oml:dependenciesmlr_2.3, RWeka_0.4.23/oml:dependencies oml:parameter oml:namebw.iters/oml:name oml:data_typeinteger/oml:data_type oml:default_value10/oml:default_value /oml:parameter oml:parameter oml:namebw.replace/oml:name oml:data_typelogical/oml:data_type oml:default_valueTRUE/oml:default_value /oml:parameter oml:parameter oml:namebw.size/oml:name oml:data_typenumeric/oml:data_type /oml:parameter oml:parameter oml:namebw.feats/oml:name oml:data_typenumeric/oml:data_type oml:default_value0.666666666666667/oml:default_value /oml:parameter oml:source_md56d9797a1c0c2a8641957caab766ec4f9/oml:source_md5 oml:component oml:identifierJ48/oml:identifier oml:implementation oml:nameclassif.J48/oml:name oml:external_version0.4-23/oml:external_version oml:descriptionLearner classif.J48 from package(s) RWeka./oml:description oml:languageEnglish/oml:language oml:dependenciesmlr_2.3, RWeka_0.4.23/oml:dependencies oml:parameter oml:nameU/oml:name oml:data_typelogical/oml:data_type /oml:parameter oml:parameter oml:nameO/oml:name oml:data_typelogical/oml:data_type /oml:parameter oml:parameter oml:nameC/oml:name oml:data_typenumeric/oml:data_type oml:default_value0.25/oml:default_value /oml:parameter oml:parameter oml:nameM/oml:name oml:data_typeinteger/oml:data_type oml:default_value2/oml:default_value /oml:parameter oml:parameter oml:nameR/oml:name oml:data_typelogical/oml:data_type /oml:parameter oml:parameter oml:nameN/oml:name oml:data_typeinteger/oml:data_type oml:default_value3/oml:default_value /oml:parameter oml:parameter oml:nameB/oml:name oml:data_typelogical/oml:data_type /oml:parameter oml:parameter oml:nameS/oml:name oml:data_typelogical/oml:data_type /oml:parameter oml:parameter oml:nameL/oml:name oml:data_typelogical/oml:data_type /oml:parameter oml:parameter oml:nameA/oml:name oml:data_typelogical/oml:data_type /oml:parameter oml:parameter oml:nameJ/oml:name oml:data_typelogical/oml:data_type /oml:parameter /oml:implementation /oml:component /oml:implementation — Reply to this email directly or view it on GitHub https://github.com/openml/OpenML/issues/118#issuecomment-70631962.
janvanrijn commented 9 years ago

Regarding the second issue, if everything is correct you should get an "XML not valid" error?

Please note that the order in which you present the elements in XML is important. You probably mixed up source_md5 and component.

(The prior issue needs a closer look from me.)

dominikkirchhoff commented 9 years ago

Thanks, Jan. Rearranging the XML fixed the latter issue.

I only got an Internal Server Error really, not an informative error XML response.

dominikkirchhoff commented 9 years ago

Jan, could you please have a look at this issue? If this works next week or so, I would be able to upload some runs as part of my thesis. :)

joaquinvanschoren commented 9 years ago

Hi Dominik,

@Jan: please correct me if I'm wrong

I looked at previous examples in WEKA, and it seems like we are uploading the flow ID instead of the name. Hence, each of the subcomponents must be registered as well. Likely this is your problem? Is seems we even add the component ID if it is the main flow itself. Here's a (working) example: http://openml.org/r/174506/output/description

Hope that helps, Joaquin

On Fri Feb 20 2015 at 5:16:45 PM dominikkirchhoff notifications@github.com wrote:

Jan, could you please have a look at this issue? If this works next week or so, I would be able to upload some runs as part of my thesis. :)

— Reply to this email directly or view it on GitHub https://github.com/openml/OpenML/issues/118#issuecomment-75278537.

dominikkirchhoff commented 9 years ago

Hi Joaquin,

thanks for trying. The subcomponent is registered with ID 662, adding this unfortunately still does not work:

<oml:run xmlns:oml="http://openml.org/openml">
  <oml:task_id>4</oml:task_id>
  <oml:implementation_id>661</oml:implementation_id>
  <oml:parameter_setting>
    <oml:name>bw.iters</oml:name>
    <oml:value>100</oml:value>
    <oml:component>661</oml:component>
  </oml:parameter_setting>
  <oml:parameter_setting>
    <oml:name>xval</oml:name>
    <oml:value>0</oml:value>
    <oml:component>662</oml:component>
  </oml:parameter_setting>
  <oml:parameter_setting>
    <oml:name>minsplit</oml:name>
    <oml:value>20</oml:value>
    <oml:component>662</oml:component>
  </oml:parameter_setting>
</oml:run>
joaquinvanschoren commented 7 years ago

@dominikkirchhoff This is a very old issue. Is this still a problem? If not, please close :).

dominikkirchhoff commented 7 years ago

It indeed is very old and I’m not really involved with this topic anymore. @giuseppec and @berndbischl, maybe you decided not to handle subcomponents for now? Or is this working?

giuseppec commented 7 years ago

We don't care about subcomponents right now. I will close.