search

openml / OpenML

Open Machine Learning
https://openml.org
BSD 3-Clause "New" or "Revised" License
664 stars 90 forks source link

Add ENVIRONMENT variable to BASE_CONFIG #626

Open joaquinvanschoren opened 6 years ago

joaquinvanschoren commented 6 years ago

index.php sets the ENVIRONMENT variable, defining whether to run the website in production or development mode. This is not ideal because a pull on the production server may inadvertedly make the production site run in development model.

If we move this variable to BASE_CONFIG.php we avoid this issue?

amueller commented 6 years ago

I'm not sure what that means. Is the ENVIRONMENT used for anything but setting the error reporting?

joaquinvanschoren commented 6 years ago

As far as I know it only suppresses warnings and errors. Jan may know more of the details.

amueller commented 6 years ago

suppresses them in the production or in the dev version?

joaquinvanschoren commented 6 years ago

only in the production version. dev shows all errors and warnings.

On Tue, 13 Feb 2018 at 00:01 Andreas Mueller notifications@github.com wrote:

suppresses them in the production or in the dev version?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/openml/OpenML/issues/626#issuecomment-365093136, or mute the thread https://github.com/notifications/unsubscribe-auth/ABpQV-7iQZcjC7opk6qnXNYZh-1dOXoMks5tUMLlgaJpZM4SC7KM .

-- Thank you, Joaquin